Show time correctly in the backup schedule UI #12012
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12012 +/- ##
============================================
- Coverage 17.56% 17.56% -0.01%
- Complexity 15544 15545 +1
============================================
Files 5909 5910 +1
Lines 529059 529208 +149
Branches 64617 64661 +44
============================================
- Hits 92941 92940 -1
- Misses 425664 425810 +146
- Partials 10454 10458 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@rosi-shapeblue a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15985 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15984 |
There was a problem hiding this comment.
@abh1sar overall the main issue has been addressed. However, I tested a flow in which the form breaks:
Steps to Reproduce
- Create scheduled backups for all schedule types.
- Delete the Daily scheduled backup.
- Navigate to Schedule -> the displayed tab is Daily, but the Time selection shown is for Hourly backups.
- Fill in the form and attempt to create a new Daily scheduled backup.
- Open the Scheduled Backups tab -> observe that the existing Hourly backup settings are overwritten.
- Delete the Hourly scheduled backup
- Recreate it
- Try adding a new Daily scheduled backup -> the displayed tab is Daily, but the Time selection shown is for Hourly backups.
Screencast.from.2025-12-11.13-49-34.webm
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Thanks for testing @RosiKyu |
|
@blueorangutan package |
|
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16063 |
* 4.22: Update templateConfig.sh to not break with directorys with space on t… (#10898) Fix VM and volume metrics listing regressions (#12284) packaging: use latest cmk release link directly (#11429) api:rename RegisterCmd.java => RegisterUserKeyCmd.java (#12259) Prioritize copying templates from other secondary storages instead of downloading them (#10363) Show time correctly in the backup schedule UI (#12012) kvm: use preallocation option for fat disk resize (#11986) Python exception processing static routes fixed (#11967) KVM memballooning requires free page reporting and autodeflate (#11932) api: create/register/upload template with empty template tag (#12234)
4 participants
Description
This PR fixes #11928
The behaviour is similar to the Create Recurring Snapshots UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Screen.Recording.2025-11-07.at.9.49.10.AM.mov
How did you try to break this feature and the system with this change?